Wrecked Games

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're just that awesome.

Pages: [1] 2

Author Topic: Consistancy  (Read 2518 times)

CaseyB

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 31
    • View Profile
Consistancy
« on: December 04, 2006, 10:09:34 PM »
I had an issue that took me a while to track down because some method calls had inconsistant capitalization.  The class is OIS::Keyboard, but to find out how many there are it's InputManager::numKeyBoards and with Joysticks it OIS::JoyStick, but InputManager::numJoysticks
Logged

pjcast

  • Administrator
  • Veteran
  • *****
  • Karma: +1/-0
  • Posts: 2661
    • View Profile
    • http://www.wreckedgames.com
Consistancy
« Reply #1 on: December 05, 2006, 07:05:28 AM »
How is the naming inconsistant? OIS uses camel case (with the exception of JoyStick, which is really just one word). Classes are captitalized all words, methods start lowercase and rest of words are capitalized.
Logged

CaseyB

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 31
    • View Profile
Consistancy
« Reply #2 on: December 05, 2006, 07:27:17 AM »
Because sometimes you capitalize the B in keyboard, ohter times not and sometimes you capitalize teh s in joystick and other times not.
Logged

pjcast

  • Administrator
  • Veteran
  • *****
  • Karma: +1/-0
  • Posts: 2661
    • View Profile
    • http://www.wreckedgames.com
Consistancy
« Reply #3 on: December 05, 2006, 07:31:34 AM »
I think the only parts where that happens is where you just listed.
Logged

CaseyB

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 31
    • View Profile
Consistancy
« Reply #4 on: December 05, 2006, 08:55:26 AM »
I could search through and submit a patch?
Logged

pjcast

  • Administrator
  • Veteran
  • *****
  • Karma: +1/-0
  • Posts: 2661
    • View Profile
    • http://www.wreckedgames.com
Consistancy
« Reply #5 on: December 05, 2006, 09:14:48 AM »
I think this change is something best suited for a new release (1.2). As, changing that interface now means updating multiple platforms, making sure they compile, ensuring compatible with Ogre Eihort (I hate changing the dependencies there too often, especialy considering Eihort is to be released this month or next month).

I have not yet branched cvs head to 1.0 yet, so commiting any code changes in a head branch is not appropritate yet. However, if you want to do a search and submit a patch, or make note of any discrepencies you find here, it can be fixed in 1.1 once the 1.0 branch is made.

Changes to 1.0 are strictly limited to problems of logic, performance, or other severe issues.
Logged

CaseyB

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 31
    • View Profile
Consistancy
« Reply #6 on: December 05, 2006, 09:29:08 AM »
Ok, I'll go through and make note of them, then submit a patch later.
Logged

pjcast

  • Administrator
  • Veteran
  • *****
  • Karma: +1/-0
  • Posts: 2661
    • View Profile
    • http://www.wreckedgames.com
Consistancy
« Reply #7 on: December 05, 2006, 09:35:27 AM »
Thanks :D
Logged

OvermindDL1

  • Administrator
  • Veteran
  • *****
  • Karma: +0/-0
  • Posts: 288
    • View Profile
    • http://www.overminddl1.com/forum/
Consistancy
« Reply #8 on: December 05, 2006, 01:27:58 PM »
I noticed those, bugged me as well.  I would not mind at all if they were made consistent, be better to fix it in my app as well.
Logged

pjcast

  • Administrator
  • Veteran
  • *****
  • Karma: +1/-0
  • Posts: 2661
    • View Profile
    • http://www.wreckedgames.com
Consistancy
« Reply #9 on: December 05, 2006, 02:44:50 PM »
I guess I should take it as a compliment that the only issues so far are with a few naming quirks and nothing else ;)
Logged

CaseyB

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 31
    • View Profile
Consistancy
« Reply #10 on: December 05, 2006, 05:12:32 PM »
Quote from: "pjcast"
I guess I should take it as a compliment that the only issues so far are with a few naming quirks and nothing else ;)
Absolutely!  Other than that one, triffling thing I couldn't be more pleased!
Logged

vectrex

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 33
    • View Profile
    • http://www.kartsim.com
Consistancy
« Reply #11 on: December 06, 2006, 05:39:36 AM »
consistant naming seems to be a v1.0 'thing' to me. But I don't care as I use visual assist so I rarely type anything completely :)
Logged

CaseyB

  • Regular
  • *
  • Karma: +0/-0
  • Posts: 31
    • View Profile
Consistancy
« Reply #12 on: December 06, 2006, 06:20:20 AM »
Well, if pjcast decides it is a 1.0 "thing" then I can make the patch asap, but otherwise I'll hold off.
Logged

pjcast

  • Administrator
  • Veteran
  • *****
  • Karma: +1/-0
  • Posts: 2661
    • View Profile
    • http://www.wreckedgames.com
Consistancy
« Reply #13 on: December 06, 2006, 07:29:38 AM »
Quote from: "vectrex"
consistant naming seems to be a v1.0 'thing' to me. But I don't care as I use visual assist so I rarely type anything completely :)


I would say 99.9% of OIS is cosistant. A couple little quirks do not make OIS an inconsistant library. And in anycase, this is too late for 1.0. In case you missed, 1.0RC1 is out already, meaning the API is locked, only bugs and serious errors will be correct at this point ;)
Logged

OvermindDL1

  • Administrator
  • Veteran
  • *****
  • Karma: +0/-0
  • Posts: 288
    • View Profile
    • http://www.overminddl1.com/forum/
Consistancy
« Reply #14 on: December 06, 2006, 10:10:28 AM »
Quote from: "vectrex"
consistant naming seems to be a v1.0 'thing' to me. But I don't care as I use visual assist so I rarely type anything completely :)

Ditto. :)
Although my VA is rather ancient (they've upped their prices a few times since I last bought it, out of my price range now).  Still works perfect for me.
Logged
Pages: [1] 2
« previous next »